Re: [PATCH 5/5] ARM: asm/div64.h: adjust to generic codde

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Nicolas,

[auto build test WARNING on asm-generic/master]
[also WARNING on: v4.3 next-20151103]

url:    https://github.com/0day-ci/linux/commits/Nicolas-Pitre/div64-h-optimize-do_div-for-power-of-two-constant-divisors/20151103-065348
base:   https://github.com/0day-ci/linux Nicolas-Pitre/div64-h-optimize-do_div-for-power-of-two-constant-divisors/20151103-065348
config: arm-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=arm 

All warnings (new ones prefixed by >>):

   In file included from arch/arm/include/asm/div64.h:126:0,
                    from include/linux/kernel.h:136,
                    from drivers/cpufreq/s5pv210-cpufreq.c:13:
   drivers/cpufreq/s5pv210-cpufreq.c: In function 's5pv210_set_refresh':
   include/asm-generic/div64.h:217:28: warning: comparison of distinct pointer types lacks a cast
     (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                               ^
>> drivers/cpufreq/s5pv210-cpufreq.c:215:2: note: in expansion of macro 'do_div'
     do_div(tmp, freq);
     ^
>> drivers/cpufreq/s5pv210-cpufreq.c:215:2: warning: right shift count >= width of type
   In file included from include/linux/kernel.h:136:0,
                    from drivers/cpufreq/s5pv210-cpufreq.c:13:
   arch/arm/include/asm/div64.h:49:20: warning: passing argument 1 of '__div64_32' from incompatible pointer type
    #define __div64_32 __div64_32
                       ^
   include/asm-generic/div64.h:235:11: note: in expansion of macro '__div64_32'
      __rem = __div64_32(&(n), __base); \
              ^
>> drivers/cpufreq/s5pv210-cpufreq.c:215:2: note: in expansion of macro 'do_div'
     do_div(tmp, freq);
     ^
   arch/arm/include/asm/div64.h:32:24: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'
    static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
                           ^
   In file included from arch/arm/include/asm/div64.h:126:0,
                    from include/linux/kernel.h:136,
                    from drivers/cpufreq/s5pv210-cpufreq.c:13:
   include/asm-generic/div64.h:217:28: warning: comparison of distinct pointer types lacks a cast
     (void)(((typeof((n)) *)0) == ((uint64_t *)0)); \
                               ^
   drivers/cpufreq/s5pv210-cpufreq.c:219:2: note: in expansion of macro 'do_div'
     do_div(tmp1, tmp);
     ^
   drivers/cpufreq/s5pv210-cpufreq.c:219:2: warning: right shift count >= width of type
   In file included from include/linux/kernel.h:136:0,
                    from drivers/cpufreq/s5pv210-cpufreq.c:13:
   arch/arm/include/asm/div64.h:49:20: warning: passing argument 1 of '__div64_32' from incompatible pointer type
    #define __div64_32 __div64_32
                       ^
   include/asm-generic/div64.h:235:11: note: in expansion of macro '__div64_32'
      __rem = __div64_32(&(n), __base); \
              ^
   drivers/cpufreq/s5pv210-cpufreq.c:219:2: note: in expansion of macro 'do_div'
     do_div(tmp1, tmp);
     ^
   arch/arm/include/asm/div64.h:32:24: note: expected 'uint64_t *' but argument is of type 'long unsigned int *'
    static inline uint32_t __div64_32(uint64_t *n, uint32_t base)
                           ^

vim +/do_div +215 drivers/cpufreq/s5pv210-cpufreq.c

83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  199  {
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  200  	unsigned long tmp, tmp1;
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  201  	void __iomem *reg = NULL;
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  202  
d62fa311 arch/arm/mach-s5pv210/cpufreq.c   Jonghwan Choi 2011-05-12  203  	if (ch == DMC0) {
6d4ed0f4 drivers/cpufreq/s5pv210-cpufreq.c Tomasz Figa   2014-07-03  204  		reg = (dmc_base[0] + 0x30);
d62fa311 arch/arm/mach-s5pv210/cpufreq.c   Jonghwan Choi 2011-05-12  205  	} else if (ch == DMC1) {
6d4ed0f4 drivers/cpufreq/s5pv210-cpufreq.c Tomasz Figa   2014-07-03  206  		reg = (dmc_base[1] + 0x30);
d62fa311 arch/arm/mach-s5pv210/cpufreq.c   Jonghwan Choi 2011-05-12  207  	} else {
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  208  		printk(KERN_ERR "Cannot find DMC port\n");
d62fa311 arch/arm/mach-s5pv210/cpufreq.c   Jonghwan Choi 2011-05-12  209  		return;
d62fa311 arch/arm/mach-s5pv210/cpufreq.c   Jonghwan Choi 2011-05-12  210  	}
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  211  
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  212  	/* Find current DRAM frequency */
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  213  	tmp = s5pv210_dram_conf[ch].freq;
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  214  
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12 @215  	do_div(tmp, freq);
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  216  
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  217  	tmp1 = s5pv210_dram_conf[ch].refresh;
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  218  
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  219  	do_div(tmp1, tmp);
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  220  
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  221  	__raw_writel(tmp1, reg);
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  222  }
83efc743 arch/arm/mach-s5pv210/cpufreq.c   Jaecheol Lee  2010-10-12  223  

:::::: The code at line 215 was first introduced by commit
:::::: 83efc7432f881d4f4bcedd6800710c2c4c24c58d ARM: S5PV210: Add support CPUFREQ

:::::: TO: Jaecheol Lee <jc.lee@xxxxxxxxxxx>
:::::: CC: Kukjin Kim <kgene.kim@xxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: Binary data


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux