On Fri, 2015-07-17 at 10:32 +0100, Will Deacon wrote: > static inline void arch_spin_unlock(arch_spinlock_t *lock) > { > - SYNC_IO; > - __asm__ __volatile__("# arch_spin_unlock\n\t" > - PPC_RELEASE_BARRIER: : :"memory"); > + smp_mb(); > lock->slock = 0; > } That probably needs to be mb() in case somebody has the expectation that it does a barrier vs. DMA on UP. Cheers, Ben. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html