Am 11.05.2015 um 23:05 schrieb H. Peter Anvin: > On 05/10/2015 02:44 AM, Richard Weinberger wrote: >> Hi! >> >> While cleaning up UML's uaccess code I've noticed that not a single architecture >> is using VERIFY_READ/WRITE in access_ok(). >> One exception is UML, it uses the access type in one check which is in vain anyways. >> Also asm-generic/uaccess.h drops the type parameter silently. >> >> Why do we still carry it around? >> >> Is it because we want it for some future architecture which can benefit >> from it or just because nobody cared enough to do a tree-wide cleanup? >> I fear it is the latter... ;) >> > > Or, perhaps, nobody noticed? Also possible. While we are at it, access_ok() is IMHO a horrible name. Historic? Today it is used to find out whether an address is in an architecture defined range and therefore valid. Maybe valid_address() would be a better name... Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
