Hi Machael,
On 06/01/15 15:43, Michael S. Tsirkin wrote:
> virtio wants to read bitwise types from userspace using get_user. At the
> moment this triggers sparse errors, since the value is passed through an
> integer.
>
> Fix that up using __force.
>
> Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> ---
> arch/metag/include/asm/uaccess.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/metag/include/asm/uaccess.h b/arch/metag/include/asm/uaccess.h
> index 0748b0a..c314b45 100644
> --- a/arch/metag/include/asm/uaccess.h
> +++ b/arch/metag/include/asm/uaccess.h
> @@ -135,7 +135,7 @@ extern long __get_user_bad(void);
> ({ \
> long __gu_err, __gu_val; \
> __get_user_size(__gu_val, (ptr), (size), __gu_err); \
> - (x) = (__typeof__(*(ptr)))__gu_val; \
> + (x) = (__force __typeof__(*(ptr)))__gu_val; \
As I mentioned before, can you please adjust the position of the \ to
line up.
> __gu_err; \
> })
>
> @@ -145,7 +145,7 @@ extern long __get_user_bad(void);
> const __typeof__(*(ptr)) __user *__gu_addr = (ptr); \
> if (access_ok(VERIFY_READ, __gu_addr, size)) \
> __get_user_size(__gu_val, __gu_addr, (size), __gu_err); \
> - (x) = (__typeof__(*(ptr)))__gu_val; \
> + (x) = (__force __typeof__(*(ptr)))__gu_val; \
same here (this one causes checkpatch error due to 80 column limit).
> __gu_err; \
> })
>
>
With those changes,
Acked-by: James Hogan <james.hogan@xxxxxxxxxx>
Cheers
James
Attachment:
signature.asc
Description: OpenPGP digital signature
