> On Mon, Dec 15, 2014 at 12:21:27PM +0100, David Hildenbrand wrote: > > > On Wed, Dec 10, 2014 at 03:23:29PM +0100, David Hildenbrand wrote: > > > > > > Did you look at the -rt patches where this comes from? > > > > > > https://git.kernel.org/cgit/linux/kernel/git/clrkwllms/rt-linux.git/commit/?h=v3.14.21-rt9&id=b389ced19ab649438196d132768fe6522d2f052b > > > https://git.kernel.org/cgit/linux/kernel/git/clrkwllms/rt-linux.git/commit/?h=v3.14.21-rt9&id=4fb7f9d416f7b34036d9d1b209e77c462ac0ee10 > > > https://git.kernel.org/cgit/linux/kernel/git/clrkwllms/rt-linux.git/commit/?h=v3.14.21-rt9&id=c730a4aade9e5c9b84f65de01d6612bf70c577e3 > > > https://git.kernel.org/cgit/linux/kernel/git/clrkwllms/rt-linux.git/commit/?h=v3.14.21-rt9&id=d365f5bf933e988a39874b33302f02ff6c7989b7 > > > https://git.kernel.org/cgit/linux/kernel/git/clrkwllms/rt-linux.git/commit/?h=v3.14.21-rt9&id=93eb18f43dfa5d49d99e2b8ad236eea2c35dd539 > > > https://git.kernel.org/cgit/linux/kernel/git/clrkwllms/rt-linux.git/commit/?h=v3.14.21-rt9&id=8947442e896921e1b645f9e1fd0f2beee103bba0 > > > > > > > > > > Thanks for the links - haven't seen these patches so far (somebody on the list > > just mentioned that someone tried to demangle that stuff some time ago). But > > good to know that somebody is working on that pagefault_disable() thing. > > > > Do you know what the plans for this series are? So I can base my patches > > (might_sleep() checks for might_fault()) on that queue. > > As stated in that other email, there's no active work on this atm. Its > just what -rt needed the pagefault_{en,dis}able() bits for. I think we > should try and merge some of that upstream now that there is a stronger > use case. > Ah, now I get it. So the main question is which approach is better: a) -rt version: Store the pagefault_count in struct task_struct() b) my version: Storing it in thread_info IOW: My series first and the -rt part (pagefault handlers, preempt fixup) on top or -rt version first and my work (patch 3 + 4 ) on top. Getting rid of that whole preemption handling in pagefault_disable() / fixing up the pagefault handlers is something I would have addressed in future patches, but that part seems to be just fine in the -rt code. Thanks for having a look! David -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
