On Thu, Sep 25, 2014 at 11:33 AM, Will Deacon <will.deacon@xxxxxxx> wrote: >> Putting them here means they won't have any multiple include protection >> (there is no "#ifndef _IO_H" around them). Doesn't seem to lead to >> any problems in practice. Just flagging it... > > That's easy enough to fix, and actually, we should have __KERNEL__ checks > here too. Fixup below. Why do we need __KERNEL__ checks? <asm/io.h> is not exported. BTW, it seems there are many __KERNEL__ checks in arch/*/include/asm/ we don't need. Or do I need more coffee? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html