Re: [PATCH] core: fix typo in percpu read_mostly section

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 01, 2014 at 12:11:47PM -0700, Filipe Brandenburger wrote:
> From: Zhengyu He <hzy@xxxxxxxxxx>
> 
> This fixes a typo that named the read_mostly section of percpu as
> readmostly. It works fine with SMP because the linker script specifies
> .data..percpu..readmostly. However, UP kernel builds don't have percpu
> sections defined and the non-percpu version of the section is called
> data..read_mostly, so .data..readmostly will float around and may break
> things unexpectedly.
> 
> Looking at the original change that introduced data..percpu..readmostly
> (commit c957ef2c59e952803766ddc22e89981ab534606f), it looks like this
> was the original intention.
> 
> Tested: Built UP kernel and confirmed the sections got merged.
> 
> - Before the patch:
> $ objdump -h vmlinux.o  | grep '\.data\.\.read.*mostly'
> 38 .data..read_mostly 00004418  0000000000000000  0000000000000000  00431ac0  2**6
> 50 .data..readmostly 00000014  0000000000000000  0000000000000000  00444000  2**3
> 
> - After the patch:
> $ objdump -h vmlinux.o  | grep '\.data\.\.read.*mostly'
> 38 .data..read_mostly 00004438  0000000000000000  0000000000000000  00431ac0  2**6
> 
> Signed-off-by: Zhengyu He <hzy@xxxxxxxxxx>
> Signed-off-by: Filipe Brandenburger <filbranden@xxxxxxxxxx>

Applied to percpu/for-3.16-fixes.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux