Hi Steven, On 06/26/2014 07:35 PM, Steven Rostedt wrote: > On Thu, 26 Jun 2014 12:52:41 -0400 > Steven Rostedt <rostedt@xxxxxxxxxxx> wrote: > >> From: "Steven Rostedt (Red Hat)" <rostedt@xxxxxxxxxxx> >> >> Nothing sets function_trace_stop to disable function tracing anymore. >> Remove the check for it in the arch code. > > From the cover letter, you were not Cc'd on. > > Anyway, as there is no more reason to set function_trace_stop it is time > to remove it. Unfortunately it's in several archs in assembly. Most of > the assembly looks rather straight forward and I removed them myself. > But I was only able to compile test them (for archs: arm64, metag, and > microblaze I do not have my cross tools set up for them and did not > even compile test it). But I would really love it if people can > download their patch and test it out. You only need the patches that go > against your arch and to really test it, also include the patch titled: > > ftrace: Remove check for HAVE_FUNCTION_TRACE_MCOUNT_TEST > > Otherwise your arch patch will call the list op that still does the > check. That is, if you want to test suspend and resume on your arch. > > As you may see, there are patches to the ftrace infrastructure that > depend on the arch patches being implemented. I removed the > functionality from the infrastructure, then removed it from the archs, > and then finally removed the existence of the function_trace_stop > variable, which would cause the archs to fail to compile if that were > to go first. > > If you can test your arch and give me your acked-by, I would appreciate > it. Otherwise, if you need this to go through your tree, I would ask you > to set up a dedicated branch that I can pull from to keep this order > intact. Sadly the arch-related tracing code in parisc is really broken. It doesn't even compile cleanly on parisc (at least on 64bit), and as I wrote you in another mail I really need to fix this soon (which I already started on). But your patches look clean, so to get the basics right, I'm happy to give a Acked-by: Helge Deller <deller@xxxxxx> for the two patches which affect parisc, which are: [PATCH 08/27] parisc: ftrace: Add call to ftrace_graph_is_dead() in function graph code [PATCH 20/27] parisc: ftrace: Remove check of obsolete variable function_trace_stop It would be good if you can push them through your tree. I assume your tree is: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git with branch ftrace/next. Is this correct? If yes, I can build my patches upon this tree... Thanks! Helge -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
