Am 14.05.2014 21:34, schrieb Geert Uytterhoeven: > Hi Richard, > > On Wed, May 14, 2014 at 9:26 PM, Richard Weinberger <richard@xxxxxx> wrote: >>> But why this sudden #ifdef checks? >> >> They are needed because in pgalloc.h you have: >> #ifdef CONFIG_MMU >> #include <asm/virtconvert.h> >> #if defined(CONFIG_COLDFIRE) >> #include <asm/mcf_pgalloc.h> >> #elif defined(CONFIG_SUN3) >> #include <asm/sun3_pgalloc.h> >> #else >> #include <asm/motorola_pgalloc.h> >> #endif >> >> And only asm/motorola_pgalloc.h have __pte/pmd_free_tlb as static inline functions. >> Therefore we need to define them such that the generic tlb.h versions will not clash >> with yours. > > Thanks for the clarification! One problem which arises here is that me need to make sure that pgalloc.h is included before tlb.h. Which kind of sucks. I'll move __pte/pmd_free_tlb from *_pgalloc.h into tlb.h to prevent this issue. Are you fine with that? > Perhaps this deserves a comment: > > /* Applies to Classic m68k MMU only */ Will add. Thanks, //richard -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
