On Tue, May 13, 2014 at 5:30 PM, Jonas Bonn <jonas@xxxxxxxxxxxx> wrote: > On 05/13/2014 11:05 AM, Ley Foon Tan wrote: >> Override time_t and clock_t in include/uapi/asm-generic. >> >> diff --git a/arch/openrisc/include/uapi/asm/posix_types.h b/arch/openrisc/include/uapi/asm/posix_types.h >> new file mode 100644 >> index 0000000..5ccf37d >> --- /dev/null >> +++ b/arch/openrisc/include/uapi/asm/posix_types.h >> @@ -0,0 +1,17 @@ >> +#ifndef __ARCH_OPENRISC_POSIX_TYPES_H >> +#define __ARCH_OPENRISC_POSIX_TYPES_H >> + >> +/* >> + * This file is generally used by user-level software, so you need to >> + * be a little careful about namespace pollution etc. Also, we cannot >> + * assume GCC is being used. >> + */ > > I don't think the above comment needs to be copied to this file... given > that the file is in the uapi/ directory, we know the file is exported to > userspace, and the GCC comment isn't relevant given the rest of the > files contents. > > But that's really just a nit! Nice work, otherwise. > > Acked-by: Jonas Bonn <jonas@xxxxxxxxxxxx> I noticed most of the posix_types.h files in other archiectures have this comment. I can remove this comment if you think we don't need to add this. Thanks. Regards Ley Foon -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
