Hi Will, On 04/22/2014 05:18 PM, Will Deacon wrote: > Hi Michal, > > On Tue, Apr 22, 2014 at 03:09:46PM +0100, Michal Simek wrote: >> On 04/17/2014 03:44 PM, Will Deacon wrote: >>> Now that no architectures using asm-generic/io.h define their own relaxed >>> accessors, the dummy definitions can be used unconditionally. >>> >>> Cc: Arnd Bergmann <arnd@xxxxxxxx> >>> Signed-off-by: Will Deacon <will.deacon@xxxxxxx> >>> --- >>> include/asm-generic/io.h | 18 ------------------ >>> 1 file changed, 18 deletions(-) >> >> Do we need this? I think there could be a need to overwrite them. >> Currently we are just lucky that architecture which uses asm-generic/io.h >> don't need to overwrite it. >> But I expect that all archs should use asm-generic/io.h to clean >> architecture io.h exactly I have done it for Microblaze. > > I'm open to keeping the conditional definitions, but it introduces a > discrepancy with the non-relaxed versions, which are defined unconditionally > (although the underlying __raw_* accessors can be overridden). up to you. Thanks, Michal -- Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/ Maintainer of Linux kernel - Xilinx Zynq ARM architecture Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform
Attachment:
signature.asc
Description: OpenPGP digital signature
