On Jum, 2014-04-18 at 16:35 +0200, Sam Ravnborg wrote: > It is good practice to add build infrastructure last - so build is not broken. > But for a new architecture it matters only little. > > Some comments in the following. > > Sam Noted. But, I will keep the patch # for this time for consistency. Thanks. > > > > Signed-off-by: Ley Foon Tan <lftan@xxxxxxxxxx> > > --- > > > > diff --git a/arch/nios2/Kconfig b/arch/nios2/Kconfig > > new file mode 100644 > > index 0000000..2bd0d0d7160f31a5c5890cf8a059b9f53378be6e > > --- /dev/null > > +++ b/arch/nios2/Kconfig > > @@ -0,0 +1,213 @@ > > +config NIOS2 > > + def_bool y > > + select OF > > + select OF_EARLY_FLATTREE > > + select USB_ARCH_HAS_HCD if USB_SUPPORT > > + select ARCH_WANT_OPTIONAL_GPIOLIB > > + select GENERIC_IRQ_PROBE > > + select GENERIC_IRQ_SHOW > > + select GENERIC_CPU_DEVICES > > + select GENERIC_ATOMIC64 > > + select MODULES_USE_ELF_RELA > > + select IRQ_DOMAIN > > + select SOC_BUS > > + select CLKSRC_OF > If you keep this list sorted then merge issues are less likely. Noted, will sort this list. > > +config KERNEL_MMU_REGION_BASE_BOOL > > + bool "Set custom kernel MMU region base address" > > + depends on ADVANCED_OPTIONS > > + help > > + This option allows you to set the virtual address of the kernel MMU region. > > + > > + Say N here unless you know what you are doing. > > All Nios2 specific options should be prefixed with NIOS2_ > This is what is done for all new arch specific symbols. Noted, will add NIOS2 prefix to these CONFIGs. > > > diff --git a/arch/nios2/boot/Makefile b/arch/nios2/boot/Makefile > > + $(call if_changed,gzip) > > + > > +$(obj)/vmImage: $(obj)/vmlinux.gz > > + $(call if_changed,uimage) > > + @$(kecho) 'Kernel: $@ is ready' > > Add: > targets += vmlinux.bin vmlinux.gz vmImage > to make $(call if_changed ... actually work. Sure, will change to this way. > > > > +obj-y += cpuinfo.o insnemu.o irq.o nios2_ksyms.o process.o prom.o ptrace.o \ > > + setup.o signal.o sys_nios2.o syscall_table.o time.o traps.o > > In new stuff try to avoid using ... \ > to contatenate lines. > Use: > obj-y += xxx > > This is much more readable. > Will fix this. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
