Re: [PATCH v3 0/2] qspinlock: Introducing a 4-byte queue spinlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/30/2014 03:55 AM, Raghavendra K T wrote:
On 01/28/2014 11:49 PM, Waiman Long wrote:
v2->v3:
- Simplify the code by using numerous mode only without an unfair option.
  - Use the latest smp_load_acquire()/smp_store_release() barriers.
  - Move the queue spinlock code to kernel/locking.
  - Make the use of queue spinlock the default for x86-64 without user
    configuration.
  - Additional performance tuning.


Could you please point me to any dependency patches I am missing?
I am getting the compilation error (latest linus tree with 9b0cd304f26b9fca140de15deeac2bf357d1f388)

Got something like below

make[1]: Nothing to be done for `all'.
  CHK     include/config/kernel.release
  CHK     include/generated/uapi/linux/version.h
  CHK     include/generated/utsrelease.h
make[1]: Nothing to be done for `relocs'.
  CC      kernel/bounds.s
In file included from include/asm-generic/getorder.h:7:0,
                 from /test/master/arch/x86/include/asm/page.h:71,
                 from /test/master/arch/x86/include/asm/processor.h:17,
                 from /test/master/arch/x86/include/asm/atomic.h:6,
                 from include/linux/atomic.h:4,
                 from include/asm-generic/qspinlock.h:22,
from /test/master/arch/x86/include/asm/spinlock_types.h:15, from /test/master/arch/x86/include/asm/paravirt_types.h:331,
                 from /test/master/arch/x86/include/asm/ptrace.h:65,
                 from /test/master/arch/x86/include/asm/alternative.h:8,
                 from /test/master/arch/x86/include/asm/bitops.h:16,
                 from include/linux/bitops.h:33,
                 from include/linux/kernel.h:10,
                 from include/asm-generic/bug.h:13,
                 from /test/master/arch/x86/include/asm/bug.h:38,
                 from include/linux/bug.h:4,
                 from include/linux/page-flags.h:9,
                 from kernel/bounds.c:9:
include/linux/log2.h: In function ‘__ilog2_u32’:
include/linux/log2.h:34:2: error: implicit declaration of function ‘fls’ [-Werror=implicit-function-declaration]
include/linux/log2.h: In function ‘__ilog2_u64’:
include/linux/log2.h:42:2: error: implicit declaration of function ‘fls64’ [-Werror=implicit-function-declaration]
include/linux/log2.h: In function ‘__roundup_pow_of_two’:
.
.
[trimmed]


The code will need to be compiled in either the latest linux tree as the patches have dependency on some new memory barrier that are in 3.14. Alternatively, you can compile with the latest tip tree.

If you have already done that, please send me your config file so that I can reproduce the compilation error in my build environment.

Thanks,
Longman
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux