On Fri, Nov 08, 2013 at 10:28:18AM +0000, Mathieu Desnoyers wrote:
> (forwarded due to SMTP issues)
> > > +#define smp_mb__before_atomic_dec() barrier()
> > > +#define smp_mb__after_atomic_dec() barrier()
> > > +#define smp_mb__before_atomic_inc() barrier()
> > > +#define smp_mb__after_atomic_inc() barrier()
> >
> > Maybe split the before/after atomic inc/dec change to a separate patch ?
> > This seems to remove before/after atomic inc/dec for hexagon, but I
> > don't see where they are added back ?
Oops, yeah, split these two into a separate patch.
> > > +#ifndef nop
> > > +#define nop() asm volatile ("nop")
> > > +#endif
> > >
> >
> > I don't really understand why "no-op" sits within barrier.h. It might be
> > a lack of imagination on my part though.
Yeah, not sure either..
> > Other than that
> >
> > Reviewed-by: Mathieu Desnoyers <mathieu.desnoyers@xxxxxxxxxxxx>
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
