On 10/29/2013 09:59 PM, David Howells wrote: > Chen Gang <gang.chen@xxxxxxxxxxx> wrote: > >>>>> For "kernel/modsign_certificate.S", I recommend to expand the macro >>>>> which will shrink code line, either need not include additional header >>>>> file, I feel that will be simpler for both code reader and writers. >>> I recommend leaving that file alone. That gets moved to a .S file in patches >>> queued in the security tree. >> >> Excuse me, I am not quite familiar with our version merging, I guess >> your meaning is "this file will be removed, and the related contents >> will be in another .S file, so we need not fix it within this file". >> >> If what I guess is correct, I support your recommendation (and if what I >> guess is incorrect, please let me know, thanks). :-) > > Sorry, I misread what you were saying. The code has already been split out of > the .c file of course (I'd forgotten that it had). In the security tree next > branch, the .S file gets renamed and slightly modified here: > > http://git.kernel.org/cgit/linux/kernel/git/jmorris/linux-security.git/commit/?h=next&id=b56e5a17b6b9acd16997960504b9940d0d7984e7 > Oh, thank you for your information, and I will send patch v3 for it. I need/should based on another next-tree branch, and use its tag "next-20131025" to continue (which already contents original related changes). And also, excuse me, my English is not quite well (which easily lead other members misunderstanding). Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
