On Fri, Sep 13, 2013 at 2:44 AM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > On Thu, Sep 12, 2013 at 10:38 PM, Josh Boyer <jwboyer@xxxxxxxxxxxxxxxxx> wrote: >> On Thu, Sep 12, 2013 at 11:36 AM, Chris Mason <chris.mason@xxxxxxxxxxxx> wrote: >>> Mark Fasheh (4): >>> btrfs: offline dedupe >> >> This commit adds calls to __put_user_unaligned, which causes build >> failures on ARM if btrfs is configured: >> >> + make -s ARCH=arm V=1 -j4 modules >> fs/btrfs/ioctl.c: In function 'btrfs_ioctl_file_extent_same': >> fs/btrfs/ioctl.c:2802:3: error: implicit declaration of function >> '__put_user_unaligned' [-Werror=implicit-function-declaration] >> if (__put_user_unaligned(info.status, &args->info[i].status) || >> ^ >> cc1: some warnings being treated as errors >> make[2]: *** [fs/btrfs/ioctl.o] Error 1 >> make[1]: *** [fs/btrfs] Error 2 >> make[1]: *** Waiting for unfinished jobs.... >> make: *** [fs] Error 2 >> make: *** Waiting for unfinished jobs.... > > Cfr. my early warning 10 days ago: > > "Btrfs is the first user of __put_user_unaligned() outside the compat code, > hence now all 32-bit architectures should make sure to implement this, too." > > http://marc.info/?l=linux-arch&m=137820065929216&w=2 Indeed. I missed that as it was an m68k patch. I'm not an ARM expert, so I don't know if ARM should use the asm-generic implementations, or just use __get_user/__put_user in all cases. I've CC'd rmk. josh -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
