On Thu, Sep 12, 2013 at 10:32:04PM +0200, Sam Ravnborg wrote: > On Thu, Sep 12, 2013 at 02:53:58PM -0400, Mark Salter wrote: > > Remove messy dependencies from PARPORT_PC by having it depend on one > > Kconfig symbol (ARCH_MAY_HAVE_PC_PARPORT) and having architectures > > which need it declare ARCH_MAY_HAVE_PC_PARPORT in arch/*/Kconfig. > > New architectures are unlikely to need PARPORT_PC, so this avoids > > having an ever growing list of architectures to exclude. Those > > architectures which do declare ARCH_MAY_HAVE_PC_PARPORT in this > > patch are the ones which have an asm/parport.h. > > It is much nicer if you provide a config symbol only once. > And then let the architectures who want it select this symbol. > > This is the pattern we use for similar things in many places today, > so it is best to follow that pattern. Yes, and if you do, please be sensitive to the files you're editing. If you find yourself adding a "select" statement at the bottom of an already sorted list, then you're probably going to make someone less than happy. (I've just re-sorted arch/arm/Kconfig's select statements after they've become mis-sorted - originally sorted alphabetically at akpm's request to avoid conflicts. It now has a comment at the end of the main list asking for new additions to be appropriately placed.) -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
