[PATCH 0/4] asm-generic: fix minor include guard issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I wrote a script to help find (potential) problems with include
guards, such as the same macro being used in different header
files. These patches are the result of applying that to
include/asm-generic. They are mostly trivial, but [1/4] fixes two
almost-problems.

I didn't touch include/asm-generic/rwsem.h, although it might need
some attention. It was introduced in dd472da38, seemingly a copy of
arch/powerpc/include/asm/rwsem.h, which was removed in 0766387bc. It
is not #included from anywhere, but is used in
arch/{hexagon,powerpc}/include/asm/Kbuild. Since it is no longer
powerpc-specific, the _ASM_POWERPC_RWSEM_H and #ifdef CONFIG_PPC64
seem malplaced.


Rasmus Villemoes (4):
  asm-generic: Make sure include guards contain the substring
    ASM_GENERIC
  asm-generic: Use different include guards
  asm-generic: Add missing include guards
  asm-generic: Fix typo in comment after #endif

 include/asm-generic/bitops/arch_hweight.h   |    2 +-
 include/asm-generic/bitops/atomic.h         |    2 +-
 include/asm-generic/cacheflush.h            |    6 +++---
 include/asm-generic/clkdev.h                |    4 ++--
 include/asm-generic/dma-coherent.h          |    4 ++--
 include/asm-generic/dma-contiguous.h        |    4 ++--
 include/asm-generic/dma-mapping-broken.h    |    6 +++---
 include/asm-generic/dma-mapping-common.h    |    4 ++--
 include/asm-generic/ide_iops.h              |    4 ++++
 include/asm-generic/io-64-nonatomic-hi-lo.h |    6 +++---
 include/asm-generic/io-64-nonatomic-lo-hi.h |    6 +++---
 include/asm-generic/iomap.h                 |    4 ++--
 include/asm-generic/memory_model.h          |    4 ++--
 include/asm-generic/pci_iomap.h             |    2 +-
 include/asm-generic/rtc.h                   |    6 +++---
 include/asm-generic/signal.h                |    2 +-
 include/asm-generic/statfs.h                |    4 ++--
 include/asm-generic/syscall.h               |    6 +++---
 include/asm-generic/unistd.h                |    5 +++++
 include/asm-generic/vga.h                   |    2 +-
 include/asm-generic/word-at-a-time.h        |    6 +++---
 include/asm-generic/xor.h                   |    4 ++++
 22 files changed, 53 insertions(+), 40 deletions(-)

-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux