On 06/27/2013 04:29 PM, Catalin Marinas wrote: > On Thu, Jun 27, 2013 at 05:03:25AM +0100, Chen Gang wrote: >> > If an architecture need "generic pci.h", it also need generic "pci-dma- >> > compat.h", so recommend to include it in asm-generic directly. >> > >> > And now, for arm64 and m32r, may cause compiling error about it. >> > >> > The related error (with allmodconfig): >> > >> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_exit’: >> > drivers/media/usb/b2c2/flexcop-usb.c:393:3: error: implicit declaration of function ‘pci_free_consistent’ [-Werror=implicit-function-declaration] >> > drivers/media/usb/b2c2/flexcop-usb.c: In function ‘flexcop_usb_transfer_init’: >> > drivers/media/usb/b2c2/flexcop-usb.c:410:2: error: implicit declaration of function ‘pci_alloc_consistent’ [-Werror=implicit-function-declaration] >> > drivers/media/usb/b2c2/flexcop-usb.c:410:21: warning: assignment makes pointer from integer without a cast [enabled by default] >> > cc1: some warnings being treated as errors >> > >> > >> > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> > From the arm64 perspective: > > Acked-by: Catalin Marinas <catalin.marinas@xxxxxxx> > Thanks. > (but make sure it doesn't break other archs) I will try to check all related archs with allmodconfig (which can also find more another patches, and can let me familiar the compiler step by step). ;-) Thanks. -- Chen Gang -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html