On Sun, Jun 09, 2013 at 02:31:42PM +0800, Chen Gang wrote: > > atomic_set_mask() and atomic_clear_mask() are the pairs, so the related > parameters' type need match with each other. > > The type of 'addr->counter' is 'int', so use 'unsigned int' instead > of 'unsigned long', and let atomic_set_mask() match atomic_clear_mask(). > > > For arch sub-system, currently, have 3 types of definition for them: > 1st for 'int', 2nd for 'long', 3rd is conflict to use 'int' and 'long'. > > At least, better to fix 3rd (conflict using 'int' and 'long'). > > Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx> > --- > arch/blackfin/include/asm/atomic.h | 4 ++-- > arch/m32r/include/asm/atomic.h | 8 ++++---- > arch/s390/include/asm/atomic.h | 4 ++-- > include/asm-generic/atomic.h | 2 +- > 4 files changed, 9 insertions(+), 9 deletions(-) For the s390 part: Acked-by: Heiko Carstens <heiko.carstens@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html