Thorsten, >> No need for the #ifdef CONFIG_Q40 - Q40 is the only m68k subarch that builds >> the parport_pc module (which includes parport.h), IIRC. Is that correct, >> Thorsten? > > The header is included outside of Q40. There is no Q40 kernel > in Debian (yet). So, no. OK, so it's the Amiga use of parport_pc that you had issues with. I really should stop relying on my increasingly fuzzy memory. Looking at the arch defconfigs, neither Amiga or Atari defines CONFIG_PARPORT_PC. Is this driver used on any m68k subarch at all? At this stage I'm not even certain it is in fact used on Q40. Anyway, back to the patch at hand: any change to parport_pc.h should not affect m68k at all, so you're free to patch this any way you please. Changes to m68k asm/io.h should be avoided unless shown to cause no harm to existing drivers. I can't see direct use of insl/outsl in Atari m68k drivers I checked, but due to the slightly tangled nature of m68k io.h, these may get pulled in through macros yet. I'd prefer the code stays as-is. Regards, Michael 2013/6/6 Thorsten Glaser <tg@xxxxxxxxx>: > schmitz dixit: > >> No need for the #ifdef CONFIG_Q40 - Q40 is the only m68k subarch that builds >> the parport_pc module (which includes parport.h), IIRC. Is that correct, >> Thorsten? > > The header is included outside of Q40. There is no Q40 kernel > in Debian (yet). So, no. > > bye, > //mirabilos > -- > 17:08⎜«Vutral» früher gabs keine packenden smartphones und so > 17:08⎜«Vutral» heute gibts frauen die sind facebooksüchtig > 17:10⎜«Vutral» aber auch traurig; früher warst du als nerd voll am arsch > 17:10⎜«Vutral» heute bist du als nerd der einzige der wirklich damit klarkommt -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
