On Thu, May 30, 2013 at 09:18:43AM +0800, Chen Gang wrote:
>
> 'boot_args' is an input args, and 'boot_command_line' has a fix length.
>
> So need use strlcpy() instead of strcpy() to avoid memory overflow.
>
>
> Signed-off-by: Chen Gang <gang.chen@xxxxxxxxxxx>
> ---
> arch/parisc/kernel/setup.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/arch/parisc/kernel/setup.c b/arch/parisc/kernel/setup.c
> index 60c1ae6..7349a3f 100644
> --- a/arch/parisc/kernel/setup.c
> +++ b/arch/parisc/kernel/setup.c
> @@ -69,7 +69,8 @@ void __init setup_cmdline(char **cmdline_p)
> /* called from hpux boot loader */
> boot_command_line[0] = '\0';
> } else {
> - strcpy(boot_command_line, (char *)__va(boot_args[1]));
> + strlcpy(boot_command_line, (char *)__va(boot_args[1]),
> + COMMAND_LINE_SIZE);
What about add
boot_command_line[COMMAND_LINE_SIZE - 1] = '\0';
to protect the following another strcpy?
"
strcpy(command_line, boot_command_line);
"
>
> #ifdef CONFIG_BLK_DEV_INITRD
> if (boot_args[2] != 0) /* did palo pass us a ramdisk? */
> --
> 1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
