On Tue, Apr 30, 2013 at 05:30:42PM +0100, Steve Capper wrote: > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 41179b0..e1dc5ae 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c ... > +pte_t *huge_pte_offset(struct mm_struct *mm, unsigned long addr) > +{ > + pgd_t *pgd; > + pud_t *pud; > + pmd_t *pmd = NULL; > + > + pgd = pgd_offset(mm, addr); > + if (pgd_present(*pgd)) { > + pud = pud_offset(pgd, addr); > + if (pud_present(*pud)) { > + if (pud_large(*pud)) That's more of a question for the x86 guys - can we replace pud_large() here with pud_huge()? It looks like the former simply checks for present and huge, so pud_huge() would be enough. This saves an additional definition. -- Catalin -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html