On 30/01/13 06:34, Vineet Gupta wrote: > On Tuesday 29 January 2013 10:35 PM, James Hogan wrote: >> Hi Vineet, >> >> You don't appear to define CONFIG_HW_PERF_EVENTS, so >> include/linux/oprofile.h will presumably define oprofile_perf_init as >> just a pr_info(...); return -ENODEV; >> >> Similarly drivers/oprofile/oprofile_perf.o doesn't seem to be being built. >> >> I'm probably missing something somewhere? > > Not much :-) > > oprofile_arch_init() failure causes oprofile to fall back to timer based PC only > sampling - for coarse grained profiling. I'll soon be starting on integratign the > hardware counter support to both oprofile/perf. Okay cool. It's just slightly misleading for anybody copying the code that it calls oprofile_perf_init which is known never to do anything :-). Maybe it's worth adding a comment in there to clarify. If it's only temporary I'm fine with it. Reviewed-by: James Hogan <james.hogan@xxxxxxxxxx> Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
