On Sun, Jan 27, 2013 at 6:33 PM, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > blackfin/allmodconfig: > > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:204: error: implicit declaration of function ‘dma_mmap_coherent’ > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_get_base_sgt’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:387: error: implicit declaration of function ‘dma_get_sgtable’ > > For architectures using dma_map_ops, dma_mmap_coherent() and > dma_get_sgtable() are provided in <asm-generic/dma-mapping-common.h>. > > Blackfin does not use dma_map_ops, hence it should implement them as inline > stubs using dma_common_mmap() and dma_common_get_sgtable(). > > Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Cc: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx> > Cc: uclinux-dist-devel@xxxxxxxxxxxxxxxxxxxx > Acked-by: Scott Jiang <scott.jiang.linux@xxxxxxxxx> Thanks, Will be applied to my blackfin arch tree. > --- > v2: No changes > --- > arch/blackfin/include/asm/dma-mapping.h | 10 ++++++++++ > 1 files changed, 10 insertions(+), 0 deletions(-) > > diff --git a/arch/blackfin/include/asm/dma-mapping.h b/arch/blackfin/include/asm/dma-mapping.h > index bbf4610..054d9ec 100644 > --- a/arch/blackfin/include/asm/dma-mapping.h > +++ b/arch/blackfin/include/asm/dma-mapping.h > @@ -154,4 +154,14 @@ dma_cache_sync(struct device *dev, void *vaddr, size_t size, > _dma_sync((dma_addr_t)vaddr, size, dir); > } > > +/* drivers/base/dma-mapping.c */ > +extern int dma_common_mmap(struct device *dev, struct vm_area_struct *vma, > + void *cpu_addr, dma_addr_t dma_addr, size_t size); > +extern int dma_common_get_sgtable(struct device *dev, struct sg_table *sgt, > + void *cpu_addr, dma_addr_t dma_addr, > + size_t size); > + > +#define dma_mmap_coherent(d, v, c, h, s) dma_common_mmap(d, v, c, h, s) > +#define dma_get_sgtable(d, t, v, h, s) dma_common_get_sgtable(d, t, v, h, s) > + > #endif /* _BLACKFIN_DMA_MAPPING_H */ > -- > 1.7.0.4 > -- Regards, --Bob -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
