Re: [RFC PATCH v1 24/40] metag: DMA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/11/12 14:25, Arnd Bergmann wrote:
> On Wednesday 31 October 2012, James Hogan wrote:
>> +static inline void
>> +dma_unmap_single(struct device *dev, dma_addr_t dma_addr, size_t size,
>> +                enum dma_data_direction direction)
>> +{
>> +       BUG_ON(!valid_dma_direction(direction));
>> +       dma_sync_for_cpu((void *)bus_to_virt(dma_addr), size, direction);
>> +}
> 
> bus_to_virt is deprecated an should not be visible to device drivers
> any more for new stuff. Maybe you can remove the definition and introduce
> a __bus_to_virt() function for internal use that also returns a pointer
> type instead.

Hi Arnd,

Is there any reason not to just directly use phys_to_virt (which
bus_to_virt was defined as before)?

Thanks
James

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux