Re: [RFC PATCH v1 32/40] i8042: don't build on METAG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 09/11/12 14:28, Arnd Bergmann wrote:
> On Wednesday 31 October 2012, James Hogan wrote:
>> diff --git a/drivers/input/serio/Kconfig b/drivers/input/serio/Kconfig
>> index 55f2c22..60b2a09 100644
>> --- a/drivers/input/serio/Kconfig
>> +++ b/drivers/input/serio/Kconfig
>> @@ -22,7 +22,7 @@ config SERIO_I8042
>>         tristate "i8042 PC Keyboard controller" if EXPERT || !X86
>>         default y
>>         depends on !PARISC && (!ARM || ARCH_SHARK || FOOTBRIDGE_HOST) && \
>> -                  (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN
>> +                  (!SUPERH || SH_CAYMAN) && !M68K && !BLACKFIN && !METAG
>>         help
>>           i8042 is the chip over which the standard AT keyboard and PS/2
>>           mouse are connected to the computer. If you use these devices,
> 
> Maybe you can turn that list around and introduce a new symbol
> ARCH_HAS_SERIO_I8042 or similar that architectures can select.
> I suspect that actually most don't have this, but they have not
> bothered to update this list.

Hi Arnd,

I've starting writing some patches along these lines (for the various PC
style devices). They all seem to have slightly different rules though so
I think to be safe we need separate Kconfig symbols for each one.

With SERIO_I8042 I'm completely guessing. It defaults to y, but the only
ones I know for certain shouldn't select it are the ones currently
excluded (parisc, arm (unless shark, footbridge), superh (unless
cayman), m68k, blackfin, metag). A few I know should allow it due to
special casing of io operations (mips (jazz, sgi_has_i8042, sni_rm),
ppc, sparc, x86, ia64, unicore32). Is it okay in this case to select it
for pretty much all of the arches not excluded and let the maintainers
NAK if they don't want it?

PARPORT_PC isn't too difficult (and defaults to n), I can select
HAVE_PARPORT_PC from any arch that provides asm/parport.h or
conditionally allowed it before:
alpha, arm, ia64, m68k (if ISA), microblaze, mips, parisc, powerpc, sh,
sparc (if PCI), tile, unicore32, x86

VGA_CONSOLE isn't too bad either (but it does default to y), I can
select HAVE_VGA_CONSOLE if the arch declares a screen_info struct (which
is the link error I get on metag):
alpha, arm (only ARCH_INTEGRATOR, ARCH_FOOTBRIDGE, ARCH_NETWINDER),
cris, ia64, m32r, mips, PPC (!4xx && !8xx), score, x86, xtensa

RTC defaults to n, but I've narrowed it down to alpha, m32r, mips
(MACH_LOONSON), mn10300, and x86 which provide asm/mc146818rtc.h.

GEN_RTC defaults to n, and I've narrowed to alpha, m68k, mn10300,
parisc, ppc, x86 which provide asm/rtc.h.

Cheers
James

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux