On 11/14/2012 12:34 AM, Arnaldo Carvalho de Melo wrote:
> Em Tue, Nov 13, 2012 at 10:42:02AM -0500, Josh Boyer escreveu:
>> On Tue, Nov 13, 2012 at 10:24 AM, David Howells <dhowells@xxxxxxxxxx> wrote:
>>> Josh Boyer <jwboyer@xxxxxxxxx> wrote:
>>> tools/perf/builtin-kvm.c became x86-only with the following commit:
>>>
>>> commit bcf6edcd6fdb8965290f0b635a530fa3c6c212e1
>>> Author: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx>
>>> Date: Mon Sep 17 16:31:15 2012 +0800
>>> Subject: perf kvm: Events analysis tool
>>>
>>> when it added:
>>>
>>> +#include "../../arch/x86/include/asm/svm.h"
>>> +#include "../../arch/x86/include/asm/vmx.h"
>>> +#include "../../arch/x86/include/asm/kvm.h"
>>>
>>> and my changing these to <asm/foo.h> doesn't matter because of this in the
>>> same file:
>>>
>>> +struct exit_reasons_table vmx_exit_reasons[] = {
>>> + VMX_EXIT_REASONS
>>> +};
>>> +
>>> +struct exit_reasons_table svm_exit_reasons[] = {
>>> + SVM_EXIT_REASONS
>>> +};
>>>
>>> which use macros only x86 defines.
>>
>> Ah. You are quite right. So your patches actually fix the unistd.h
>> error we were seeing early and just got us far enough to hit this other
>> unrelated problem. My mistake.
>>
>>> Should the exported parts of these files be moved to asm-generic?
>>
>> Good question.
>
> Probably we should do Makefile changes to build 'perf kvm' only on the
> platforms where it makes sense.
Only 'perf kvm stat' command is only supported on x86, how about add
"#ifdef ARCH_X86_64" around these code?
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
