On 09/11/12 14:32, Arnd Bergmann wrote: > On Wednesday 31 October 2012, James Hogan wrote: >> >> On 31/10/12 19:30, Greg KH wrote: >>> On Wed, Oct 31, 2012 at 04:14:18PM +0000, James Hogan wrote: >>>> Add various Meta specific sysfs drivers. >>>> >>>> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx> >>> >>> As you are creating new sysfs files, please also create new >>> Documentation/ABI/ files describing what those sysfs files do at the >>> same time. >> >> Good point, I'll make sure Documentation is added. >> > > While I haven't looked at the contents of these files in much detail, > I suspect that they are not actually sysfs material at all. Anything > related to performance counters should probably go into "perf". > > You can also have your own debugfs directories if that is not a good > fit, but when these are mainly debugging helps, debugfs seems more > appropriate than sysfs. Yes, I'm planning on dropping these from the core patchset as we never use them ourselves so they're not a priority. Thanks James -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html