On 29/10/12 01:28, guanxuetao@xxxxxxxxxxxxxxx wrote: >> Including <asm/cacheflush.h> from <asm-generic/io.h> prevents >> cacheflush.h being able to use I/O functions like readl and writel due >> to circular include dependencies. It doesn't appear as if anything from >> cacheflush.h is actually used by the generic io.h, so remove the >> include. >> >> I've compile tested a defconfig compilation of blackfin, openrisc (which >> needed <asm/pgtable.h> including from it's <asm/io.h> to get the PAGE_* >> definitions), and xtensa. >> >> Other architectures which use asm-generic/io.h are score and unicore32, >> and looking at their io.h I don't see any obvious problems. >> >> Signed-off-by: James Hogan <james.hogan@xxxxxxxxxx> >> Cc: Arnd Bergmann <arnd@xxxxxxxx> >> Cc: Jonas Bonn <jonas@xxxxxxxxxxxx> >> Cc: Chris Zankel <chris@xxxxxxxxxx> >> Cc: Max Filippov <jcmvbkbc@xxxxxxxxx> >> Cc: Mike Frysinger <vapier@xxxxxxxxxx> >> Cc: Chen Liqin <liqin.chen@xxxxxxxxxxxxx> >> Cc: Lennox Wu <lennox.wu@xxxxxxxxx> >> Cc: Guan Xuetao <gxt@xxxxxxxxxxxxxxx> > > Acked-by: Guan Xuetao <gxt@xxxxxxxxxxxxxxx> Thanks Guan Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
