On 09/29/2012 02:08 PM, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 13:32 Fri 28 Sep , Stephen Warren wrote: >> From: Stephen Warren <swarren@xxxxxxxxxx> >> >> All architectures that use cmd_dtc do so in the same way. Move the build >> rule to a central location to avoid duplication. >> >> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx> >> --- >> Jean-Christophe, >> Moving the build rule to Makefile.lib rather than Makefile.build seems >> reasonable to me; the dtc-related logic is already in Makefile.lib, and >> for features where cmd_* is defined in Makefile.lib, the associated >> build rule is also defined there. I see no reason for this patch series >> to move all the dtc-related logic into Makefile.build. > > build rules are in Makefile.build c to o , s to o etc... As I explicitly pointed out above, your statement is simply not true; there are many build rules in Makefile.lib. > so put it in Makefile.build is the correct place ditto fot the dtc cmd As such, I'm just going to ignore that feedback. Perhaps the kbuild maintainer (oops, who I forgot to CC; I'll forward him the patches) can weigh in though. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
