Re: [PATCH] Make most arch asm/module.h files use asm-generic/module.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 18, 2012 at 02:24:00PM +0100, David Howells wrote:
> David Howells <dhowells@xxxxxxxxxx> wrote:
> 
> > Hi Rusty, Arnd,
> > 
> > Here's a patch to asm-genericise the arch asm/module.h files.  It allows four
> > of them to be deleted outright.  MIPS is the only weirdo of the bunch.
> > 
> > The patch can also be found here:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/dhowells/linux-modsign.git;a=shortlog;h=refs/heads/for-rusty
> > 
> > David
> 
> No sooner had I pushed that than Fengguang Wu found a bug in it.  I've pushed a
> new version to the GIT tree which will find its way to gitweb at some point.
> 
> The problem was that I defined the new config options within the:
> 
> 	if MODULES
> 	...
> 	endif # MODULES
> 
> section within init/Kconfig - but they're statements of fact about the arch and
> are not dependent on whether or not modules are configured.

Stuff like this is better situated in arch/Kconfig.
This is not related to the init part but to the configuration of the
architecture.
For historical reasons we used to use init/Kconfig for this in
the past - but now that we have arch/Kconfig let's use it.

	Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux