On Sat, Jun 9, 2012 at 6:14 AM, Paul Mundt <lethal@xxxxxxxxxxxx> wrote: > On Sat, Jun 09, 2012 at 05:13:26AM -0300, Ezequiel Garcia wrote: >> This patch removes the following warning: >> fs/binfmt_flat.c:752: warning: unused variable ???persistent??? >> There is neither change in functionality, nor extra code generated. >> >> Cc: Paul Mundt <lethal@xxxxxxxxxxxx> >> Cc: <linux-sh@xxxxxxxxxxxxxxx> >> Signed-off-by: Ezequiel Garcia <elezegarcia@xxxxxxxxx> > > That's what the cast was for, with what gcc version did that stop > working? Mmm. You're right. I did this change first for m68k [1] and when that went ok, I decided it was best to propagate this fix to every other arch. Originally, my first try was to propagate your cast: #define flat_set_persistent(relval, p) ({ (void)p; 0; }) to the other arches, that just do: #define flat_set_persistent(relval, p) 0 But, then someone pointed out that inlining would produce some (nil) code and it seemed better. To conclude: sh was the only one doing it right, and there is no good reason to change it, except to make code more homogeneous. Hope it is clear now, Ezequiel. [1] https://lkml.org/lkml/2012/5/21/491 -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html