Re: [PATCH 01/10] Use __kernel_long_t in struct timex

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/17/2012 03:56 PM, Linus Torvalds wrote:
On Thu, May 17, 2012 at 3:50 PM, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx>  wrote:

I think __word would be good too, *except* for the fact that
especially in x86 land, I think there's the legacy confusion with
"word" being 16-bit. Ugh.

Looking at the x32 case, I have to say that "long" in general looks
horrible. Especially when we have things like

   typedef long long __kernel_long_t;

(and __long really wouldn't look any nicer). Any sane person would go
"Eww" at looking at that - we're using 'long long' to typedef a type
that is named 'long'.

It would make much more sense to use "__word" for reasons like that.
But I really don't think that works well in a x86 context.

Other ideas? Maybe "__wordsize" would be less associated with x86 16-bit words?


FWIW: "__abi_wordsize" to indicate that it is not really a property of the machine itself, but rather the ABI in use.

David Daney

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux