Calling interrupt_return will check the privilege of the context we're returning to avoid the possibility of kernel threads doing any kind of userspace actions (including signal handling) after a fork. Signed-off-by: Chris Metcalf <cmetcalf@xxxxxxxxxx> --- Al, thanks for noticing this. I've queued it up for 3.4. Do you have a case that might provoke the signal behavior in the unpatched code? The patched code passes our internal regressions. arch/tile/kernel/intvec_32.S | 2 +- arch/tile/kernel/intvec_64.S | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/tile/kernel/intvec_32.S b/arch/tile/kernel/intvec_32.S index 5d56a1e..d0f48ca 100644 --- a/arch/tile/kernel/intvec_32.S +++ b/arch/tile/kernel/intvec_32.S @@ -1274,7 +1274,7 @@ STD_ENTRY(ret_from_fork) FEEDBACK_REENTER(ret_from_fork) { movei r30, 0 /* not an NMI */ - j .Lresume_userspace /* jump into middle of interrupt_return */ + j interrupt_return } STD_ENDPROC(ret_from_fork) diff --git a/arch/tile/kernel/intvec_64.S b/arch/tile/kernel/intvec_64.S index 49d9d66..252924b 100644 --- a/arch/tile/kernel/intvec_64.S +++ b/arch/tile/kernel/intvec_64.S @@ -1120,7 +1120,7 @@ STD_ENTRY(ret_from_fork) FEEDBACK_REENTER(ret_from_fork) { movei r30, 0 /* not an NMI */ - j .Lresume_userspace /* jump into middle of interrupt_return */ + j interrupt_return } STD_ENDPROC(ret_from_fork) -- 1.6.5.2 -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html