On Sun, Feb 19, 2012 at 4:07 PM, H. Peter Anvin <hpa@xxxxxxxxx> wrote: > From: "H. J. Lu" <hjl.tools@xxxxxxxxx> > > Enable the lp driver to be used with a compat ABI with 64-bit time. Ugh. Is this really the only case? Because if it isn't, I suspect it would be much better off with a helper function. In fact, even if this *does* end up being the only place, a helper function to get/set a timeval from user space sounds like a good idea, and makes things much more readable than that ad-hoccery in the middle of code. IOW, I'd like to see something like get_user_timeval(void __user *tv, struct timeval *res) even if it would be only local to this file. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html