On Wed, 08 Feb 2012 08:55:13 -0800 "H. Peter Anvin" <hpa@xxxxxxxxx> wrote: > On 02/08/2012 01:04 AM, Martin Schwidefsky wrote: > > On Tue, 7 Feb 2012 21:09:00 -0800 > > "H. Peter Anvin" <hpa@xxxxxxxxx> wrote: > > > >> From: "H. Peter Anvin" <hpa@xxxxxxxxx> > >> > >> Change the s390 architecture to use <asm-generic/posix_types.h>. > >> > >> Signed-off-by: H. Peter Anvin <hpa@xxxxxxxxx> > >> Cc: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> > >> Cc: Heiko Carstens <heiko.carstens@xxxxxxxxxx> > >> Cc: <linux390@xxxxxxxxxx> > >> --- > >> arch/s390/include/asm/posix_types.h | 70 +++++------------------------------ > >> 1 files changed, 10 insertions(+), 60 deletions(-) > > > > I carefully checked the conversion and came to the conclusion that the new type > > definitions are equivalent to the old ones. The code compiles fine with the > > patches applied and the kernel boots. > > What I don't like is the conversion of __FD_ZERO. The new definition creates > > this code sequence: > > > > It shouldn't matter: > > a. __FD_ZERO seems to actually be unused in the current kernel. > b. The last patch in the series deletes the generic __FD_ZERO and > replaces it with memset(). If there are any magic optimizations an > architecture wants to do, they belong in memset(). Ah, cool. In this case: Acked-by: Martin Schwidefsky <schwidefsky@xxxxxxxxxx> -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
