Am Montag 30 Januar 2012, 10:40:47 schrieb James Bottomley: > The problem in > > commit fea80311a939a746533a6d7e7c3183729d6a3faf > Author: Randy Dunlap <rdunlap@xxxxxxxxxxxx> > Date: Sun Jul 24 11:39:14 2011 -0700 > > iomap: make IOPORT/PCI mapping functions conditional > > > is that if your architecture supplies pci_iomap/pci_iounmap, it expects > always to supply them. Adding empty body defitions in the !CONFIG_PCI > case, which is what this patch does, breaks the parisc compile because > the functions become doubly defined. It took us a while to spot this, > because we don't actually build !CONFIG_PCI very often (only if someone > is brave enough to test the snake/asp machines). > > Since the note in the commit log says this is to fix a > CONFIG_GENERIC_IOMAP issue (which it does because CONFIG_GENERIC_IOMAP > supplies pci_iounmap only if CONFIG_PCI is set), there should actually > have been a condition upon this. This should make sure no other > architecture's !CONFIG_PCI compile breaks in the same way as parisc. > > The fix had to be updated to take account of the GENERIC_PCI_IOMAP > separation. So this means we end up still building the PA-RISC PCI code even if the config says no PCI. That doesn't really sound consistent to me. I really would have expected that we do not build any non-void PCI code then. > Reported-by: Rolf Eike Beer <eike@xxxxxxxxxx> I used the wrong email account when sending out the last patch where you took that from, please change that to the address used in this mail. Eike
Attachment:
signature.asc
Description: This is a digitally signed message part.
