On Mon, Jan 16, 2012 at 16:50, Andrew Jones <drjones@xxxxxxxxxx> wrote:
> On Mon, Jan 16, 2012 at 04:40:47PM +0100, Jerome Marchand wrote:
>> > @@ -1259,8 +1259,7 @@ config SLUB
>> > a slab allocator.
>> >
>> > config SLOB
>> > - depends on EXPERT
>> > - bool "SLOB (Simple Allocator)"
>> > + bool "SLOB (Simple Allocator)" if EXPERT
>> > help
>> > SLOB replaces the stock allocator with a drastically simpler
>> > allocator. SLOB is generally more space efficient but
>>
>> Am I missing something or this particular chunk does not actually change
>> anything?
>
> No, you're correct. There's no actual change, so the hunk could be dubbed
> as an unnecessary cleanup. I made the change in order to give it the same
> general format as the rest of the expert options in that file.
There _is_ a difference:
- "depends on EXPERT" means the option cannot be enabled by the user.
"select SLOB" will still override that, but kconf will print a warning.
- "bool ... if EXPERT" means the question will only be asked if EXPERT.
Other Kconfig logic can still "select SLOB" if it wants to.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
