Andi Kleen <andi@xxxxxxxxxxxxxx> wrote: > David Howells <dhowells@xxxxxxxxxx> writes: > > > > There is no need to display val here in the case the expression fails > > since it can only be 0. If this fails, it produces an error like the > > following: > > > > ------------[ cut here ]------------ > > kernel BUG at fs/fscache/main.c:109! > > ASSERTION FAILED > > It would be nice to display the expression here like an user space > assert. While it can be looked up in the source it would > make quick eyeballing easier. > > Probably wouldn't cost too much additional text size? It can easily be made selectable. I don't think text size should be much of an issue - but it will also add a bunch of strings (preprocessed expressions) to the rodata, and I'm not sure how big those can get - particularly if they've got nested macros within (test_bit() for example). David -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
