Re: [PATCH 1/3] X86_64: Optimise fls(), ffs() and fls64()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



H. Peter Anvin <hpa@xxxxxxxxx> wrote:

> > +#if BITS_PER_LONG == 32
> >  #include <asm-generic/bitops/fls64.h>
> > +#endif
> >  
> 
> This is outside __KERNEL__, and thus ends up changing what is exported
> to userspace (specifically, fls64.h won't be included for 64-bit
> non-__KERNEL__ anymore.)  Is this a bug?

It moved in the following commit:

	commit d57594c203b1e7b54373080a797f0cbfa4aade68
	Author: Alexander van Heukelum <heukelum@xxxxxxxxxxxxx>
	Date:   Sat Mar 15 18:32:36 2008 +0100

	    bitops: use __fls for fls64 on 64-bit archs

	    Use __fls for fls64 on 64-bit archs. The implementation for
	    64-bit archs is moved from x86_64 to asm-generic.

	    Signed-off-by: Alexander van Heukelum <heukelum@xxxxxxxxxxx>
	    Signed-off-by: Ingo Molnar <mingo@xxxxxxx>

So I think it's a bug.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux