Re: [PATCH] dma-mapping: fix sync_single_range_* DMA debugging

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 15 Oct 2011 23:09:51 +0200
Clemens Ladisch <clemens@xxxxxxxxxx> wrote:

> Commit 5fd75a7850b5 (dma-mapping: remove unnecessary sync_single_range_*
> in dma_map_ops) unified not only the dma_map_ops but also the
> corresponding debug_dma_sync_* calls.  This led to spurious WARN()ings
> like the following because the DMA debug code was no longer able to
> detect the DMA buffer base address without the separate offset parameter:
> 
> WARNING: at lib/dma-debug.c:911 check_sync+0xce/0x446()
> firewire_ohci 0000:04:00.0: DMA-API: device driver tries to sync DMA memory it has not allocated [device address=0x00000000cedaa400] [size=1024 bytes]
> Call Trace: ...
>  [<ffffffff811326a5>] check_sync+0xce/0x446
>  [<ffffffff81132ad9>] debug_dma_sync_single_for_device+0x39/0x3b
>  [<ffffffffa01d6e6a>] ohci_queue_iso+0x4f3/0x77d [firewire_ohci]
>  ...
> 
> To fix this, unshare the sync_single_* and sync_single_range_*
> implementations so that we are able to call the correct debug_dma_sync_*
> functions.
> 
> Signed-off-by: Clemens Ladisch <clemens@xxxxxxxxxx>
> ---
>  include/asm-generic/dma-mapping-common.h |   14 ++++++++++++--
>  1 files changed, 12 insertions(+), 2 deletions(-)

Acked-by: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux