On Monday 08 August 2011, Mark Salter wrote: > Signed-off-by: Mark Salter <msalter@xxxxxxxxxx> These definitely need some explanation about what the two drivers actually do. In fact, a lot of the patches you sent seem to lack any description whatsoever. Also, the settings that you put into the drivers are hardcoded in soc-specific code. It would be much better to integrate all this into the device tree probing mechanism. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html