Re: [PATCH 15/24] C6X: cache control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Arnd Bergmann <arnd@xxxxxxxx> wrote:

> > +#define IMCR_BASE	  0x01840000
> 
> Please don't hardcode MMIO regions like this. You should have the base
> address in the device tree and use of_iomap() like you do in some other
> cases.  If you need this really early, you might need to

What about for memory-mapped CPU registers that you might need to access in
head.S?

MN10300, for example, has a bunch of these - such the atomic operation
parameter and control registers.  Getting some of these through the device
tree adds potentially quite a lot of overhead.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-arch" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel]     [Kernel Newbies]     [x86 Platform Driver]     [Netdev]     [Linux Wireless]     [Netfilter]     [Bugtraq]     [Linux Filesystems]     [Yosemite Discussion]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Device Mapper]

  Powered by Linux