On Tue, Aug 2, 2011 at 14:30, Paul Gortmaker wrote: > [Re: [RFC/PULL 00/11] introduce export.h; reduce module.h usage] On 28/07/2011 (Thu 06:19) Linus Torvalds wrote: >> On Wed, Jul 27, 2011 at 10:16 PM, Paul Gortmaker wrote: >> > For all 160 commits, the branch "module.h-split", available here: >> > >> > git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git >> > >> > has the complete content. I've put the header changes after all the >> > patches from the top 5 categories, so that people bisecting non related >> > issues at a later date don't get hit with a commit zone with build failures. >> >> Ok, sounds good. Two questions: >> >> - how much testing (randconfig? different architectures?) has this gotten? >> >> - how much does this actually improve compile times (for a "normal" >> build or a "allmodconfig" one)? >> >> It certainly sounds like the RightThing(tm) to do, but I'd like to >> know that there is real actual improvements to build times and that >> the pain won't be too bad... > > Now that it has done time in linux-next, let me address the testing > and (hopefully lack of) pain part. Blackfin is broken because of this. a simple grep of the tree probably could pick this up. maybe something like: grep EXPORT_SYMBOL * -rIl | xargs grep -L linux/export.h from my logs, i see at least: arch/blackfin/kernel/dma-mapping.c:103: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/kernel/dma-mapping.c:111: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/kernel/dma-mapping.c:121: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/kernel/dma-mapping.c:136: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/kernel/dma-mapping.c:148: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/kernel/sys_bfin.c:50: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mach-bf518/boards/ezbrd.c:825: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mach-bf527/boards/ad7160eval.c:852: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mach-bf527/boards/ezbrd.c:876: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mach-bf527/boards/ezkit.c:1317: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mach-bf527/boards/tll6527m.c:938: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mach-bf537/boards/dnp5370.c:396: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mm/init.c:22: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' arch/blackfin/mm/init.c:32: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:1002: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:107: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:1089: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:124: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:271: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:293: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:353: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:373: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:451: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:515: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:591: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:599: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:610: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:621: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:775: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:786: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:797: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:90: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' sound/soc/blackfin/bf5xx-sport.c:968: warning: type defaults to 'int' in declaration of 'EXPORT_SYMBOL' -mike -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
