[Re: [RFC/PULL 00/11] introduce export.h; reduce module.h usage] On 01/08/2011 (Mon 13:49) Geert Uytterhoeven wrote: > Hi Paul, > > On Fri, Jul 29, 2011 at 03:20, Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> wrote: > > On Thu, 28 Jul 2011 11:42:29 -0400 Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > >> [Re: [RFC/PULL 00/11] introduce export.h; reduce module.h usage] On 28/07/2011 (Thu 09:15) Ingo Molnar wrote: > >> > >> > * Paul Gortmaker <paul.gortmaker@xxxxxxxxxxxxx> wrote: > >> > > >> > > I don't think there really is any rocket science or contentious > >> > > stuff here. It is a sensible cleanup that adds organization and > >> > > speeds up compiles. The RFC I'm hoping for is more about how/when > >> > > we want to get this in tree. > >> > > >> > I'd suggest to stick it into linux-next ASAP, leave there for a few > >> > days and after fixing any potential fallout send it Linuswards. > >> > >> Hi Stephen, > >> > >> Would you please add this to linux-next? > >> > >> git://git.kernel.org/pub/scm/linux/kernel/git/paulg/linux.git#module.h-split > > > > OK, I will add it today. > > This causes several failures in m68k defconfig (and allmodconfig, FWIW): > > http://kisskb.ellerman.id.au/kisskb/buildresult/4428037/ > (http://kisskb.ellerman.id.au/kisskb/buildresult/4414683/) > > Still recovering from holidays, so no patches attached. I grabbed a m68k toolchain (and several others I didn't have) and expanded the arch support outside of the original testing I did on x86/x86_64/mips/arm/powerpc/sparc to include m68k. So your defconfig is restored green again, once it comes around in the build (it appears down in the order) -- and for the modconfig, it hasn't been building green for a while, but I still went over the log looking for and fixing any module.h related fallout. I've just double checked it again and attached a local defconfig build log below. Thanks, Paul. paul@yow-lpgnfs-02:~/git/module.h/linux-2.6.git$ make O=../m68k-def -j50 2>&1 |grep 'warning:\|error:' <stdin>:1522:2: warning: #warning syscall recvmmsg not implemented <stdin>:1554:2: warning: #warning syscall sendmmsg not implemented /home/paul/git/module.h/linux-2.6.git/arch/m68k/mvme147/config.c:152:2: warning: #warning check me! /home/paul/git/module.h/linux-2.6.git/arch/m68k/mvme16x/config.c:261:2: warning: #warning check me! /home/paul/git/module.h/linux-2.6.git/security/keys/keyctl.c:1521:2: warning: #warning TIF_NOTIFY_RESUME not implemented /home/paul/git/module.h/linux-2.6.git/kernel/async.c:272:10: warning: 'starttime.tv64' may be used uninitialized in this function /home/paul/git/module.h/linux-2.6.git/kernel/async.c:123:10: warning: 'calltime.tv64' may be used uninitialized in this function /home/paul/git/module.h/linux-2.6.git/drivers/md/dm.c:1052:3: warning: statement with no effect /home/paul/git/module.h/linux-2.6.git/drivers/md/dm.c:1079:3: warning: statement with no effect /home/paul/git/module.h/linux-2.6.git/drivers/md/dm-table.c:1193:2: warning: statement with no effect /home/paul/git/module.h/linux-2.6.git/drivers/input/misc/hp_sdc_rtc.c:280:12: warning: 'hp_sdc_rtc_set_rt' defined but not used /home/paul/git/module.h/linux-2.6.git/drivers/input/misc/hp_sdc_rtc.c:320:12: warning: 'hp_sdc_rtc_set_fhs' defined but not used /home/paul/git/module.h/linux-2.6.git/drivers/input/misc/hp_sdc_rtc.c:360:12: warning: 'hp_sdc_rtc_set_i8042timer' defined but not used /home/paul/git/module.h/linux-2.6.git/drivers/input/misc/hp_sdc_rtc.c:112:20: warning: ignoring return value of 'down_interruptible', declared with attribute warn_unused_result /home/paul/git/module.h/linux-2.6.git/drivers/input/misc/hp_sdc_rtc.c:179:20: warning: ignoring return value of 'down_interruptible', declared with attribute warn_unused_result /home/paul/git/module.h/linux-2.6.git/drivers/input/misc/hp_sdc_rtc.c:183:20: warning: ignoring return value of 'down_interruptible', declared with attribute warn_unused_result /home/paul/git/module.h/linux-2.6.git/include/net/netfilter/xt_log.h:50:3: warning: value computed is not used /home/paul/git/module.h/linux-2.6.git/include/net/netfilter/xt_log.h:50:3: warning: value computed is not used /home/paul/git/module.h/linux-2.6.git/drivers/scsi/libsas/sas_scsi_host.c:117:3: warning: case value '2' not in enumerated type 'enum exec_status' paul@yow-lpgnfs-02:~/git/module.h/linux-2.6.git$ ls -l ../m68k-def/vmlinux -rwxr-xr-x 1 paul paul 4951289 2011-08-02 00:59 ../m68k-def/vmlinux paul@yow-lpgnfs-02:~/git/module.h/linux-2.6.git$ -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
