On Saturday 02 July 2011 21:54:26 Jonas Bonn wrote: > On Sat, 2011-07-02 at 21:46 +0200, Arnd Bergmann wrote: > > On Saturday 02 July 2011 17:53:26 Jonas Bonn wrote: > > > Use the CONFIG_HAS_IOPORT and CONFIG_PCI options to decide whether or > > > not functions for mapping these areas are provided. > > > > > > Signed-off-by: Jonas Bonn <jonas@xxxxxxxxxxxx> > > > > Good catch! > > > > Acked-by: Arnd Bergmann <arnd@xxxxxxxx> > > > > Did you get a build error without the two options, or did you just have an > > idea to save a bit of code size? > > > > There was no build error; I just figured it would aid in debugging if > you got a compile-time error when trying to build drivers that use these > functions for a platform that lacked them. Smaller code is always nice, > too. Right. Did you also see the related discussion at http://lkml.org/lkml/2011/7/1/422 ? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
