On Sat, 2011-07-02 at 12:38 -0400, Mike Frysinger wrote: > On Sat, Jul 2, 2011 at 11:53, Jonas Bonn wrote: > > Some of the implementations, in particular the ioremap variants, in > > asm-generic/io.h are for systems with an MMU. > > do you mean "without an MMU" ? Yes, of course... that's supposed to be _without_ an MMU. > > > +#ifdef CONFIG_MMU > > +#define xlate_dev_mem_ptr(p) __va(p) > > +#else > > #define xlate_dev_mem_ptr(p) ((void *) (p)) > > +#endif > > i wonder if we could do: > #ifndef __va > #define __va(p) ((void *)(p)) > #endif > #define xlate_dev_mem_ptr(p) __va(p) > -mike This seems to introduce an artificial definition of a "virtual" address for systems without an MMU, which strikes me as a bit odd. If this is what people prefer, that's fine... I think I prefer the former variant, though. /Jonas -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
