* Jonas Bonn <jonas@xxxxxxxxxxxx> wrote: > +/* This configures the module loader code to use the default implementations > + * for the architecture specific hooks. Architectures should set a #define > + * for each of the hooks that it needs to override. > + */ please use the standard (multi-line) comment style: /* * Comment ..... * ...... goes here. */ specified in Documentation/CodingStyle. (there are similar problems elsewhere in the patch as well.) Also, and more importantly, don't we generally do such things via __weak aliases, because the result looks cleaner and needs no changes for architectures beyond the removal of the generic functions? We have excluded broken toolchains that miscompile/mislink __weak IIRC so __weak ought to work. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
