On Mon, 2011-06-13 at 18:33 +0900, Akinobu Mita wrote: > 2011/6/13 Guan Xuetao <gxt@xxxxxxxxxxxxxxx>: > > Thanks, please review following patch: > > Looks good to me. Could I add your acked-by information on this patch? > > > diff --git a/arch/unicore32/kernel/ksyms.c > > b/arch/unicore32/kernel/ksyms.c > > index a897080..d98bd81 100644 > > --- a/arch/unicore32/kernel/ksyms.c > > +++ b/arch/unicore32/kernel/ksyms.c > > @@ -24,8 +24,8 @@ > > > > #include "ksyms.h" > > > > -EXPORT_SYMBOL(__uc32_find_next_zero_bit); > > -EXPORT_SYMBOL(__uc32_find_next_bit); > > +EXPORT_SYMBOL(find_next_zero_bit); > > +EXPORT_SYMBOL(find_next_bit); > > I'm wondering why there are no EXPORT_SYMBOL for find_first_bit > and find_first_zero_bit. IMO, only functions that are needed by modules should be exported. When building modules under unicore32 & pkunity-soc, we only need find_next_bit and find_next_zero_bit exported at present, and if new functions are required, I am going to add them in the same time. In fact, I think, the 'arch-generic' ksyms.c is a better idea. Guan Xuetao -- To unsubscribe from this list: send the line "unsubscribe linux-arch" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
